Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme caching #647

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix theme caching #647

merged 1 commit into from
Aug 21, 2019

Conversation

elegaanz
Copy link
Member

  • The directory was wrong, which led to 404 errors
  • reads_to_string was consuming the File, so the response was always empty

Fixes #645

@elegaanz elegaanz added C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed A: Backend Code running on the server labels Aug 21, 2019
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #647 into master will increase coverage by 0.04%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
+ Coverage   35.06%   35.11%   +0.04%     
==========================================
  Files          68       68              
  Lines        7945     7943       -2     
  Branches     1890     1889       -1     
==========================================
+ Hits         2786     2789       +3     
+ Misses       4383     4374       -9     
- Partials      776      780       +4

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔… 👍

@elegaanz elegaanz merged commit 28fb504 into master Aug 21, 2019
@elegaanz elegaanz deleted the fix-theme-caching branch August 21, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Backend Code running on the server C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 on the cached data
2 participants