Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill entirely user on creation #657

Merged
merged 1 commit into from
Aug 27, 2019
Merged

fill entirely user on creation #657

merged 1 commit into from
Aug 27, 2019

Conversation

trinity-1686a
Copy link
Contributor

fix #635

(untested, someone should check on plume-ci if it works fine)

@trinity-1686a trinity-1686a added C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed A: Backend Code running on the server labels Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #657 into master will decrease coverage by 0.3%.
The diff coverage is 73.33%.

@@            Coverage Diff            @@
##           master    #657      +/-   ##
=========================================
- Coverage   35.11%   34.8%   -0.31%     
=========================================
  Files          68      68              
  Lines        7943    7946       +3     
  Branches     1889    1884       -5     
=========================================
- Hits         2789    2766      -23     
- Misses       4374    4404      +30     
+ Partials      780     776       -4

@elegaanz
Copy link
Member

(I "played" a little bit with my server yesterday, and it looks like plume-ci is down now. I'll restart it for future branches and test this one locally)

Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work!

@elegaanz elegaanz merged commit ddbec3f into master Aug 27, 2019
@elegaanz elegaanz deleted the bugfix/635 branch August 27, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Backend Code running on the server C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to register an account
2 participants