Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make search items optional #693

Merged
merged 2 commits into from
Nov 10, 2019
Merged

make search items optional #693

merged 2 commits into from
Nov 10, 2019

Conversation

trinity-1686a
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 6, 2019 •
edited
Loading

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          72       72           
  Lines        9498     9498           
  Branches     2265     2265           
=======================================
  Hits         3728     3728           
  Misses       4713     4713           
  Partials     1057     1057

elegaanz
elegaanz reviewed Nov 7, 2019
View reviewed changes
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an indentation issue, but otherwise 👌

elegaanz
elegaanz approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elegaanz elegaanz merged commit c484ca6 into master Nov 10, 2019
@elegaanz elegaanz deleted the search-optional branch November 10, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elegaanz elegaanz elegaanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trinity-1686a @elegaanz