"Manually" (with SQL) fill the default timelines #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elegaanz
added
C: Bug
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 39.25% 39.32% +0.07%
==========================================
Files 72 72
Lines 9498 9498
Branches 2265 2265
==========================================
+ Hits 3728 3735 +7
+ Misses 4713 4706 -7
Partials 1057 1057 |
igalic
suggested changes
Nov 16, 2019
igalic
reviewed
Nov 16, 2019
| INSERT INTO timeline (post_id, timeline_id) SELECT posts.id, (SELECT id FROM timeline_definition WHERE query = 'local' LIMIT 1) FROM blogs INNER JOIN posts ON posts.blog_id = blogs.id WHERE blogs.instance_id = 1; | ||
|
|
||
| -- Add all articles to the the federated timeline | ||
| INSERT INTO timeline (post_id, timeline_id) SELECT posts.id, (SELECT id FROM timeline_definition WHERE query = 'all' LIMIT 1) FROM posts; |
There was a problem hiding this comment.
so how come this one isn't enough?
There was a problem hiding this comment.
These are not the same timelines/feeds, we need to add posts to both of them (do you want me to explain that in a comment too?)
|
Superseded by #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692
Adding a plm command was too much refactoring (because the timelines need a
PlumeRocketwhileplmonly has aConnection), so I didn't do it.