Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on runtime-fmt #773

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

OddBloke
Copy link
Contributor

Per the issue, "runtime-fmt uses perma-unstable rust APIs and is
therefore susceptible to breakage".

This replaces the two calls to rt_format! with .replace() and drops the
dependency.

Fixes #769

Per the issue, "runtime-fmt uses perma-unstable rust APIs and is
therefore susceptible to breakage".

This replaces the two calls to rt_format! with .replace() and drops the
dependency.

Fixes Plume-org#769
@OddBloke
Copy link
Contributor Author

I tested that this is the appropriate replace() invocation by writing the following temporary test:

mod tests {
    #[test]
    fn temp_test() {
        let template = format!(
            "https://{}/remote_interact?target={{uri}}",
            "some_public_domain"
        );
        assert_eq!(
            template.replace("{uri}", "substitute"),
            rt_format!(template, uri = "substitute").unwrap()
        );
    }
}

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #773 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   38.96%   38.96%           
=======================================
  Files          73       73           
  Lines        9730     9730           
  Branches     2227     2227           
=======================================
  Hits         3791     3791           
  Misses       4885     4885           
  Partials     1054     1054           

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@igalic igalic merged commit efb76a3 into Plume-org:master May 18, 2020
@OddBloke
Copy link
Contributor Author

Thanks for the merge!

@OddBloke OddBloke deleted the bug/769 branch May 18, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove dependency on runtime-fmt
2 participants