Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show boosts and likes for "all" and "local" in timelines #781

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

elegaanz
Copy link
Member

The fix was quite easy actually 😅 I think it is just that it wasn't clear enough for us that local/all shouldn't match boosts and likes, but only new posts.

Fixes #711

@elegaanz elegaanz added C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed A: Backend Code running on the server labels Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #781 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   39.08%   39.07%   -0.02%     
==========================================
  Files          73       73              
  Lines        9736     9736              
  Branches     2227     2227              
==========================================
- Hits         3805     3804       -1     
+ Misses       4879     4878       -1     
- Partials     1052     1054       +2     

@elegaanz elegaanz merged commit 297d9fc into master Jun 15, 2020
@elegaanz elegaanz deleted the dedup-articles branch June 15, 2020 17:50
@Chostakovitch
Copy link
Contributor

Marvellous ! Thank you ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Backend Code running on the server C: Bug Something isn't working S: Ready for review This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated articles in timelines
3 participants