Switch from NET Core 3.1 to NET 5.0 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased my branch to line up with current. |
crowbar27
added a commit
to crowbar27/Primes
that referenced
this pull request
May 26, 2021
|
I'm closing this. Next to Dave's solution that he has chosen to use .NET Core 3.1 for, we now have two separate C# solutions in place in the drag-race branch that are based on .NET 5.0. |
q3w3e3
pushed a commit
to q3w3e3/Primes
that referenced
this pull request
Apr 5, 2022
Clean-up of collateral files/directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many folks will present the argument that .NET 5's performance improvement will change the result. I have changed the TFM of the C# project to
net5.0(which is the moniker for .NET 5.0).On my 11th gen i9, 64GB RAM system and the results before and after are indistinguishable. However, this is anecdotal and should be seen by any visitor to the code.
Therefore, I propose that you should merge this anyways.
Other included improvements: