Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP with inlined amd64 assembler #944

Merged
merged 3 commits into from
Nov 21, 2023
Merged

CPP with inlined amd64 assembler #944

merged 3 commits into from
Nov 21, 2023

Conversation

hildenborg
Copy link
Contributor

Description

Multithreaded CPP with inlined amd64 assembler.
I chosed to put it in it's own folder as it is neither fully C++ or fully assembler.

Contributing requirements

  • I read the contribution guidelines in CONTRIBUTING.md.
  • I placed my solution in the correct solution folder.
  • I added a README.md with the right badge(s).
  • I added a Dockerfile that builds and runs my solution.
  • I selected drag-race as the target branch.
  • All code herein is licensed compatible with BSD-3.

@rbergen
Copy link
Contributor

rbergen commented Nov 7, 2023

@hildenborg As you describe it this is a mixed language solution, for which the PrimeMixed directory already exists. This solution would then become the one in directory PrimeMixed/solution_5.

@hildenborg
Copy link
Contributor Author

I didn't see the mixed language category. Moved into the correct place now.

Copy link
Contributor

@rbergen rbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the mixed language category. Moved into the correct place now.

Not a problem, one of the reasons I'm here. :)

I took the liberty of setting the execute bit on run.sh, without which the solution wouldn't run. With that, it LGTM.

As this is a new solution in a new mix of languages, I will ask for a second review from @marghidanu also.

@rbergen rbergen requested a review from marghidanu November 12, 2023 12:48
@rbergen
Copy link
Contributor

rbergen commented Nov 21, 2023

Merging based on "he who is silent agrees".

@rbergen rbergen merged commit 3547d6e into PlummersSoftwareLLC:drag-race Nov 21, 2023
163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants