Add timeout to benchmark solution runs #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging after out-of-band review by @davepl. |
rbergen
added a commit
that referenced
this pull request
Oct 20, 2024
* Use latest Julia version to represent current performance (#972) * Use latest Julia version to represent current performance * Use latest stable 1.X version * Add timeout to benchmark solution runs (#977) * Added formatting and removed deprecated attributes syntax (#982) Co-authored-by: Tudor Marghidanu <tudor@f2pool.io> --------- Co-authored-by: Christian Guinard <28689358+christiangnrd@users.noreply.github.com> Co-authored-by: Tudor Marghidanu <marghidanu@users.noreply.github.com> Co-authored-by: Tudor Marghidanu <tudor@f2pool.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've found that on certain systems/in certain situations, benchmark runs can get stuck for reasons that are unclear. This adds a timeout for each of the solution runs kicked off during the benchmark.
The default timeout is 10 minutes, this can be changed by a new make variable that's also been added to the documentation.
Contributing requirements
drag-raceas the target branch.