Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make scripts portable across unix systems #2435

Merged
merged 2 commits into from
May 22, 2023

Conversation

MathRdt
Copy link

@MathRdt MathRdt commented Mar 27, 2023

Permet aux développeurs n'ayant pas le $PATH classique /bin/bash (i.e MacOS) de pouvoir executer les scripts d'installation/migration.

Cette notation est plus flexible et permet d'assouplir les restrictions sur l'environnement de développement des collaborateurs.

https://www.cyberciti.biz/tips/finding-bash-perl-python-portably-using-env.html

requirements pour install_all:
merge :

Bump des versions de taxhub et usershub dans la version prenant en compte ces changements dans le git submodule

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (47c806c) 69.12% compared to head (d81c04a) 69.12%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2435   +/-   ##
========================================
  Coverage    69.12%   69.12%           
========================================
  Files           82       82           
  Lines         7107     7107           
========================================
  Hits          4913     4913           
  Misses        2194     2194           
Flag Coverage Δ
pytest 69.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/geonature/utils/command.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MathRdt
Copy link
Author

MathRdt commented Mar 27, 2023

Je ne suis pas sûr de comment résoudre le codecov/patch sur le fichier commands.py, qui ne semble pas être soumis aux tests unitaires

@bouttier bouttier added this to the 2.13 milestone Mar 27, 2023
@camillemonchicourt camillemonchicourt modified the milestones: triage, 2.13 May 22, 2023
@bouttier bouttier merged commit 7904a63 into PnX-SI:develop May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants