Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(permissions): remove modules objects inheritance permissions #2479

Merged
merged 6 commits into from
May 4, 2023
Merged

feat(permissions): remove modules objects inheritance permissions #2479

merged 6 commits into from
May 4, 2023

Conversation

VincentCauchois
Copy link
Member

ref #2474

@VincentCauchois VincentCauchois self-assigned this Apr 13, 2023
@VincentCauchois VincentCauchois added database SQL backend python Pull requests that update Python code labels Apr 13, 2023
@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch from 395ce3a to c509338 Compare April 13, 2023 12:19
@bouttier bouttier changed the base branch from develop to refact/permissions April 14, 2023 15:17
@bouttier bouttier force-pushed the refact/permissions branch from a3dc602 to 5c9b00c Compare April 14, 2023 16:34
@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch from f878a50 to ab0d4cf Compare April 17, 2023 16:11
@VincentCauchois VincentCauchois marked this pull request as ready for review April 17, 2023 17:16
@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch 3 times, most recently from 0fec8f5 to cb2bc40 Compare April 18, 2023 09:59
@bouttier bouttier force-pushed the refact/permissions branch from 5c9b00c to 900d334 Compare April 18, 2023 11:22
@bouttier bouttier force-pushed the feat/remove_module_object_inheritance_permissions branch 3 times, most recently from 83dd954 to 095f514 Compare April 18, 2023 13:28
@VincentCauchois VincentCauchois changed the title feat(permissions): remove module object inheritance permissions feat(permissions): remove modules objects inheritance permissions Apr 18, 2023
@bouttier bouttier force-pushed the feat/remove_module_object_inheritance_permissions branch from 095f514 to 2c57261 Compare April 18, 2023 15:14
@VincentCauchois VincentCauchois marked this pull request as draft April 20, 2023 10:17
@bouttier bouttier force-pushed the feat/remove_module_object_inheritance_permissions branch from 2c57261 to b44176f Compare April 20, 2023 12:16
@bouttier bouttier changed the base branch from refact/permissions to refact/tests April 20, 2023 12:19
@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch from b44176f to 75c98ee Compare April 20, 2023 13:02
@bouttier bouttier mentioned this pull request Apr 20, 2023
Merged
28 tasks
@bouttier bouttier force-pushed the feat/remove_module_object_inheritance_permissions branch from 5119303 to c8f3758 Compare April 21, 2023 09:35
@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch from c8f3758 to 75c98ee Compare April 21, 2023 09:45
@bouttier bouttier force-pushed the feat/remove_module_object_inheritance_permissions branch from 75c98ee to c8f3758 Compare April 21, 2023 09:51
bouttier

This comment was marked as duplicate.

Sign in to view

@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch 2 times, most recently from a4b3d61 to 50bb073 Compare April 21, 2023 16:19
@VincentCauchois VincentCauchois force-pushed the feat/remove_module_object_inheritance_permissions branch 2 times, most recently from ad1917c to 77a7a70 Compare April 28, 2023 15:59
Base automatically changed from refact/tests to refact/permissions May 4, 2023 15:29
VincentCauchois and others added 6 commits May 4, 2023 17:33
@VincentCauchois @bouttier
Remove modules and objects permissions inheritance
939c37a 
Signed-off-by: VincentCauchois <vincent.cauchois@mnhn.fr>
@VincentCauchois @bouttier
Update test_permissions
cdca277 
Remove tests for modules and objects inheritance.
Add a test for no module or no object specified for `_get_permissions` (and thus for `get_scopes_by_action`)
@VincentCauchois @bouttier
Update docs about permissions admin.
e810fc9 
Remove the line about modules and objects inheritance, in the section "Récapitulatif".

Remove reference to the view `gn_permissions.v_users_permissions` not existing anymore. The view, actually named `v_roles_permissions`, is removed by the Alembic migration "cec41a6d3a15".

Signed-off-by: VincentCauchois <vincent.cauchois@mnhn.fr>
@bouttier
module access allowed as soon as one perm exists
0e5633e 
Any permission (for any action) on any module objects (or 'ALL' object) grant access to the module.
@VincentCauchois @bouttier
Add a migration to inherit permissions for modules and objects
1e9437d
@bouttier
permissions: remove scope 0
9d033eb 
All permissions with scope 0 filter are removed.
@bouttier bouttier force-pushed the feat/remove_module_object_inheritance_permissions branch from 78790ff to 9d033eb Compare May 4, 2023 15:43
@bouttier bouttier merged commit 9d033eb into refact/permissions May 4, 2023
@bouttier bouttier deleted the feat/remove_module_object_inheritance_permissions branch May 4, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouttier bouttier bouttier left review comments

Assignees

@VincentCauchois VincentCauchois

Labels
backend database python Pull requests that update Python code SQL
Projects
Refonte permissions et sensibilité
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentCauchois @bouttier