Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(https://github.com/PnX-SI/gn_mobile_occtax/issues/264): name permissions from applicationId #47

Merged

Conversation

PaulLabruyere
Copy link

@PaulLabruyere PaulLabruyere commented Sep 20, 2024

This pull request changes the way read and write permissions are named, in order to use the applicationId defined for the app in occtax/build.gradle file. This makes more convenient for developpers to create an application that can be installed and used alongside other Occtax applications.

Also, add some documentation in the style_theme.adoc section to better explain how to perform this customization, and the implication of such a modification.

@sgrimault
Copy link
Collaborator

remove unnecessary/obsolete resources:

  • commons/src/main/res/values/strings.xml
  • commons/src/main/res/values-fr/strings.xml

@sgrimault sgrimault changed the title Allow applicationId customization fix(PnX-SI#264): name permissions from applicationId Sep 20, 2024
@sgrimault sgrimault changed the title fix(PnX-SI#264): name permissions from applicationId fix(https://github.com/PnX-SI/gn_mobile_occtax/issues/264): name permissions from applicationId Sep 20, 2024
@sgrimault sgrimault merged commit 0f430a6 into PnX-SI:develop Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants