Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: add providers & update sdk #113

Merged
merged 26 commits into from
Jan 2, 2023
Merged

[Feature]: add providers & update sdk #113

merged 26 commits into from
Jan 2, 2023

Conversation

lucas-louis
Copy link
Member

@lucas-louis lucas-louis commented Dec 23, 2022

Description

  • Update the SDK of aleph to the v3.2.0
  • Change the generation of AES encryption key
  • Change the encryption method by using :
    • Either the one of Aleph for the encryption of data into messages (by using the .encrypt & .decrypt method provided by the SDK)
    • Or the one of crypto for the encryption of the content of the file (by using the AES generated encryption key)

With this version, the upload & the share of any file (even files with headers) worked 🚀

⚠️ The addition of the providers is working, but we can't encrypt/ decrypt with it, because of the public key exposed by the providers (Metamask) ⚠️

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Change the encryption method & the AES key generation.
⚠️ Old encrypted files could not be decrypted with the new system ⚠️

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@lucas-louis lucas-louis added the enhancement New feature or request label Dec 23, 2022
@lucas-louis lucas-louis self-assigned this Dec 23, 2022
@lucas-louis lucas-louis linked an issue Dec 23, 2022 that may be closed by this pull request
4 tasks
@lucas-louis lucas-louis changed the title feat: add providers & new sdk feat: add providers & update sdk Dec 23, 2022
@lucas-louis lucas-louis changed the title feat: add providers & update sdk [Feature]: add providers & update sdk Dec 23, 2022
Dockerfile Outdated Show resolved Hide resolved
src/components/file/UploadFile.tsx Outdated Show resolved Hide resolved
src/components/file/detailsFile/DetailsFile.tsx Outdated Show resolved Hide resolved
src/components/file/detailsFile/DrawerDetailsFile.tsx Outdated Show resolved Hide resolved
src/components/file/detailsFile/DrawerDetailsFile.tsx Outdated Show resolved Hide resolved
src/components/file/detailsFile/DrawerDetailsFile.tsx Outdated Show resolved Hide resolved
src/components/file/detailsFile/DrawerDetailsFile.tsx Outdated Show resolved Hide resolved
src/components/file/detailsFile/DrawerDetailsFile.tsx Outdated Show resolved Hide resolved
@RezaRahemtola
Copy link
Member

Also there are conflicts with the yarn.lock apparently 😬

@RezaRahemtola RezaRahemtola merged commit 48f7544 into dev Jan 2, 2023
@RezaRahemtola RezaRahemtola deleted the feat/providers branch January 2, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Setup the provider login fix: format error for all downloaded files except files without header
4 participants