Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folders, GitHub deploy and OAuth & UI refactoring #85

Merged
merged 66 commits into from
Aug 16, 2022
Merged

Folders, GitHub deploy and OAuth & UI refactoring #85

merged 66 commits into from
Aug 16, 2022

Conversation

RezaRahemtola
Copy link
Member

@RezaRahemtola RezaRahemtola commented Aug 9, 2022 •
edited
Loading

Description

  • Program deployment from GitHub using OAuth
  • Folders implemented for the drive, with moving and deleting features
  • Design refactoring for better UX

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

All accounts must be recreated, previous accounts will throw an error

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

RezaRahemtola and others added 30 commits July 8, 2022 15:33
@RezaRahemtola
fix: Errors when reloading the dashboard (#32)
7676fd2
@RezaRahemtola
feat: Context menu handling on file right click
33a9a3e
@RezaRahemtola
feat: Path property added in IPCFile
dff474a
@RezaRahemtola
feat: isFile prop, path state and lint fixes
671ab7a
@RezaRahemtola
fix: Useless try/catch removed
84bf13b
@RezaRahemtola
feat: Folder creation started
f1128a6
@RezaRahemtola
feat: Folder card display isolated from files
41ca486
@RezaRahemtola
feat: Folder path navigation
be337c4 
Ability to click on a folder to see it‘s content
@RezaRahemtola
feat: Smooth path navigation with back button
72d38ab
@MizuriGit
feat: move file button (early stage)
ea200e6
@RezaRahemtola
feat: Separate arrays for files and folders
b66f0c7
@RezaRahemtola
fix: Refactoring and eslint warnings
ed0c718
@RezaRahemtola
fix: Permanent file move
1be46ae
@Alex-Prevot
feat: refactor button new element file, program, folder
80990b1 
Signed-off-by: Alex Prevot <alex1.prevot@epitech.eu>
@RezaRahemtola
fix: Variable names
bbd6bd3
@Alex-Prevot
refactor: display file on MyFiles
797da38 
Signed-off-by: Alex Prevot <alex1.prevot@epitech.eu>
@Alex-Prevot
refactor: dashboard on my Files add text and a legend
ec547c6 
Signed-off-by: Alex Prevot <alex1.prevot@epitech.eu>
@RezaRahemtola
feat: Move file checks
a1f446e 
Missing slashes in path handled, error on wrong path
@RezaRahemtola
feat: Package updates and new favicon
ec7f63e 
Disable console error with a favicon IPC logo, yarn.lock upgraded
@ZerLock
feat: add redeploy button to redeploy programs manually deployed + Ch…
31d2603 
…ange uploadProgram function to redeploy program
@Alex-Prevot
Merge with branh folder
3dd5122 
Signed-off-by: Alex Prevot <alex1.prevot@epitech.eu>
@Alex-Prevot
refactor: ui folder, icon and return to menu
bd620df 
Signed-off-by: Alex Prevot <alex1.prevot@epitech.eu>
@Samoten777
fix: helper text around login and signup buttons
1fdd1d1
@Samoten777
feat: reversed dashboard elements positions
f1d54b0
@Alex-Prevot
Merge branch 'feat/folders' into ui-refactoring
da5e4bb
@Alex-Prevot
Merge with branch feat/redeploy-program
a0dc00e 
Signed-off-by: Alex Prevot <alex1.prevot@epitech.eu>
@Alex-Prevot
fix: element on program card
8629b25
@Alex-Prevot
feat: added date on last upload on aleph
cdc31e7
@ZerLock
feat: Add deleteProgram function to delete program + Linter
c4b059f
@RezaRahemtola
fix: Lint and console.log
32beb9f
@RezaRahemtola RezaRahemtola added bug Something isn't working enhancement New feature or request labels Aug 9, 2022
@netlify
Copy link

netlify bot commented Aug 9, 2022 •
edited
Loading

✅ Deploy Preview for nimble-praline-605cf6 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/nimble-praline-605cf6/deploys/62f2971bcb77aa2570c868b8
😎 Deploy Preview https://deploy-preview-85--nimble-praline-605cf6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ZerLock
ZerLock approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@ZerLock ZerLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@AmozPay AmozPay requested a review from ZerLock August 9, 2022 16:42
ZerLock
ZerLock approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@ZerLock ZerLock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très bon code ! L'équipe Computing sont vraiment des bg <3 !

@RezaRahemtola RezaRahemtola added the minor Minor update (for release) label Aug 9, 2022
@RezaRahemtola RezaRahemtola removed this from the Computing - GitHub deployment milestone Aug 9, 2022
@RezaRahemtola RezaRahemtola merged commit 66f022f into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZerLock ZerLock ZerLock approved these changes

@adrienfort adrienfort Awaiting requested review from adrienfort

@lucas-louis lucas-louis Awaiting requested review from lucas-louis

Assignees

@ZerLock ZerLock

@RezaRahemtola RezaRahemtola

@AmozPay AmozPay

@Alex-Prevot Alex-Prevot

@MizuriGit MizuriGit

Labels
bug Something isn't working enhancement New feature or request minor Minor update (for release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RezaRahemtola @ZerLock @AmozPay @Alex-Prevot @MizuriGit @Samoten777