This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
fix(mem): removing kinesis batcher as possible memory leaker #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassrock
requested review from
efixler and
kschelonka
and removed request for
a team and
efixler
|
No idea why the linter wanted these changes all of a sudden.. |
bassrock
commented
Nov 30, 2023
| @@ -123,6 +123,7 @@ describe('Delete/Undelete SavedItem: ', () => { | |||
|
|
|||
| afterAll(async () => { | |||
| await writeClient().destroy(); | |||
| await readClient().destroy(); | |||
There was a problem hiding this comment.
This test needed the readClient destroyed to not hang them. I think its cause we made 2 queuries, 1 thats a mutation, 1 thats not. And we have logic that switches the client based on mutations. So when the query runs, it inits the readClient in the execution context, but we never cleaned it up.
bassrock
changed the title
kschelonka
reviewed
Nov 30, 2023
kschelonka
previously approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The mem leak from #825 continues.
I believe that it is likely the batch processor optimization that we had for Kinesis because it relied on timers and was polling. And because when removed, the tests no longer needed a forceExit param cause something was left open.
We will try deploying without the batch optimization since we should be well below kinesis limits for a good while.