Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for perspective 3 #58

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add support for perspective 3 #58

merged 1 commit into from
Nov 22, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Nov 16, 2024

Was able to workaround the below OOTB issue.


looks like an issue with perspective and cloudpickle

(ServeController pid=48713)   File "/opt/homebrew/Cellar/python@3.11/3.11.10/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 456, in result
(ServeController pid=48713)     return self.__get_result()
(ServeController pid=48713)            ^^^^^^^^^^^^^^^^^^^
(ServeController pid=48713)   File "/opt/homebrew/Cellar/python@3.11/3.11.10/Frameworks/Python.framework/Versions/3.11/lib/python3.11/concurrent/futures/_base.py", line 401, in __get_result
(ServeController pid=48713)     raise self._exception
(ServeController pid=48713)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(ServeController pid=48713)   File "/opt/homebrew/lib/python3.11/site-packages/ray/serve/_private/replica.py", line 266, in __init__
(ServeController pid=48713)     deployment_def = cloudpickle.loads(serialized_deployment_def)
(ServeController pid=48713)                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(ServeController pid=48713) AttributeError: type object 'PySyncServer' has no attribute 'new_session'

I believe this is due to global state in perspective>=3.

@timkpaine timkpaine force-pushed the tkp/perspective3 branch 2 times, most recently from 8944a18 to 8cd7d3a Compare November 16, 2024 04:25
@timkpaine timkpaine added part: dependencies PRs or issues related to dependencies lang: python PRs or issues related to Python lang: javascript PRs or issues related to Javascript type: enhancement Minor improvements labels Nov 16, 2024
@timkpaine timkpaine force-pushed the tkp/perspective3 branch 4 times, most recently from d657dd2 to 46cfd37 Compare November 16, 2024 05:07
Copy link

Test Results

2 tests   2 ✅  46s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 46cfd37.

Copy link

github-actions bot commented Nov 16, 2024

Test Results

2 tests   2 ✅  47s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a313933.

♻️ This comment has been updated with latest results.

@timkpaine timkpaine changed the title [wip] upgrade to perspective 3 Add support for perspective 3 Nov 16, 2024
@timkpaine timkpaine marked this pull request as ready for review November 16, 2024 16:32
@timkpaine timkpaine force-pushed the tkp/perspective3 branch 3 times, most recently from 36dd50d to 835804d Compare November 17, 2024 21:29
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine merged commit 7ad2f67 into main Nov 22, 2024
10 checks passed
@timkpaine timkpaine deleted the tkp/perspective3 branch November 22, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: javascript PRs or issues related to Javascript lang: python PRs or issues related to Python part: dependencies PRs or issues related to dependencies type: enhancement Minor improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants