Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PFH buffer, addes to key list even is key was found #1189

Closed
strothmw opened this issue Mar 25, 2015 · 1 comment
Closed

PFH buffer, addes to key list even is key was found #1189

strothmw opened this issue Mar 25, 2015 · 1 comment

Comments

@strothmw
Copy link
Contributor

At

https://github.com/PointCloudLibrary/pcl/blob/master/features/include/pcl/features/impl/pfh.hpp#L142

the key will be added to the key list, even if it was found at (i. e. is not new)

https://github.com/PointCloudLibrary/pcl/blob/master/features/include/pcl/features/impl/pfh.hpp#L97

Therefore the key list may contain duplicate keys and the feature map will be truncated even if it has not yet reached the allowable size in memory.
@strothmw strothmw mentioned this issue Mar 25, 2015
Closed
@taketwo
Copy link
Member

taketwo commented Apr 13, 2015

I think you are right. Could you please create a separate pull request with your solution?

strothmw added a commit to strothmw/pcl that referenced this issue May 20, 2015
@strothmw
Reverting commit that fixes PointCloudLibrary#1189 for creating branc…
bec64b1 
…h/pull request that fixes only PointCloudLibrary#1188

Revert "find redundant adding of identical keys to the key list in PFHEstimation buffer"

This reverts commit 7ccec0e.
@strothmw strothmw mentioned this issue May 20, 2015
Closed
SergioRAgostinho pushed a commit to SergioRAgostinho/pcl that referenced this issue Aug 26, 2016
@strothmw @SergioRAgostinho
find redundant adding of identical keys to the key list in PFHEstimat…
06d84ea 
…ion buffer

Closes PointCloudLibrary#1243. Fixes PointCloudLibrary#1189.
@SergioRAgostinho SergioRAgostinho mentioned this issue Aug 26, 2016
Merged
SergioRAgostinho pushed a commit to SergioRAgostinho/pcl that referenced this issue Aug 26, 2016
@strothmw @SergioRAgostinho
find redundant adding of identical keys to the key list in PFHEstimat…
1b5ef7a 
…ion buffer

Closes PointCloudLibrary#1243. Fixes PointCloudLibrary#1189.
SergioRAgostinho pushed a commit to SergioRAgostinho/pcl that referenced this issue Aug 27, 2016
@strothmw @SergioRAgostinho
find redundant adding of identical keys to the key list in PFHEstimat…
6ff1085 
…ion buffer

Closes PointCloudLibrary#1243. Fixes PointCloudLibrary#1189.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taketwo @strothmw