Consider removing mapping_ and getMapping() from PointCloud

[taketwo]

It seems that mapping_ is used only by

pcl/common/include/pcl/point_cloud.h

Lines 600 to 607 in d1d59c6

	namespace detail
	{
	template <typename PointT> boost::shared_ptr<pcl::MsgFieldMap>&
	getMapping (pcl::PointCloud<PointT>& p)
	{
	return (p.mapping_);
	}
	} // namespace detail

But getMapping() is never used in the project, so mapping_ does not need to be swapped.

PS: mapping_ and getMapping() might be removed from the project.

Originally posted by @csukuangfj in #2470 (comment)

[SergioRAgostinho]

👍 it seems to be there since the first commit a024ad2 and nothing was using it back then.

[taketwo]

Also consider moving detail::FieldMapping and MsgFieldMap to "conversions.h", because this is the only place they are used.

[stale]

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

[larshg]

This one can be closed?

[kunaltyagi]

I think so. 1.12 will take care of actually removing the variable

[larshg]

Yeah, its removed in #4341.