Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated items as scheduled in preparation of v1.12 (except concatenatePointCloud) #4341

Merged
merged 10 commits into from
Oct 10, 2020
Merged

Remove deprecated items as scheduled in preparation of v1.12 (except concatenatePointCloud) #4341

merged 10 commits into from
Oct 10, 2020

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Aug 20, 2020

No description provided.

@kunaltyagi
Copy link
Member

Should we make this dependent on #4336?

@larshg
Copy link
Contributor Author

larshg commented Aug 20, 2020

Yes, to test the deprecated macro first?

@larshg larshg force-pushed the Remove1.12Depcrecated branch 4 times, most recently from 6d90cd3 to d753fd2 Compare August 21, 2020 13:42
larshg
larshg commented Aug 21, 2020
View reviewed changes
test/common/test_io.cpp Outdated Show resolved Hide resolved
@larshg larshg force-pushed the Remove1.12Depcrecated branch 3 times, most recently from b1eb954 to 29c6f61 Compare August 24, 2020 13:10
@SergioRAgostinho SergioRAgostinho changed the title Remove 1.12 depcrecated items Remove 1.12 deprecated items Aug 25, 2020
SergioRAgostinho
SergioRAgostinho previously requested changes Aug 25, 2020
View reviewed changes
common/include/pcl/point_cloud.h Outdated Show resolved Hide resolved
common/include/pcl/point_cloud.h Show resolved Hide resolved
gpu/kinfu/tools/kinfu_app.cpp Outdated Show resolved Hide resolved
gpu/kinfu_large_scale/tools/color_handler.h Outdated Show resolved Hide resolved
segmentation/include/pcl/segmentation/euclidean_cluster_comparator.h Show resolved Hide resolved
test/common/test_io.cpp Outdated Show resolved Hide resolved
test/common/test_io.cpp Outdated Show resolved Hide resolved
test/common/test_io.cpp Outdated Show resolved Hide resolved
test/common/test_io.cpp Outdated Show resolved Hide resolved
test/common/test_io.cpp Outdated Show resolved Hide resolved
@larshg larshg mentioned this pull request Aug 26, 2020
Merged
@larshg
Copy link
Contributor Author

larshg commented Aug 26, 2020

Reverted kinfu and concatenatePointCloud.

Hopefully the old EuclideanClusterComparator is correctly removed now.

@larshg
Copy link
Contributor Author

larshg commented Aug 26, 2020 •
edited
Loading

Need to rebase this on master now, to avoid the getColor error in kinfu.

Or merge master into this?

https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=17345&view=logs&jobId=d0a7bda2-01ee-550e-f56c-ab8664f27120&j=d0a7bda2-01ee-550e-f56c-ab8664f27120&t=e76c7bc5-5686-5622-3ba1-e36139d9a40b

@kunaltyagi
Copy link
Member

Rebase now or merge now and rebase later: both are ok

@larshg larshg force-pushed the Remove1.12Depcrecated branch from bb9f64b to 558ea79 Compare August 26, 2020 13:36
@larshg larshg dismissed SergioRAgostinho’s stale review September 8, 2020 11:31

Needs to focus on other stuff.

@larshg larshg force-pushed the Remove1.12Depcrecated branch from 558ea79 to 102e3bb Compare September 8, 2020 11:38
@larshg larshg requested a review from kunaltyagi September 8, 2020 11:39
kunaltyagi
kunaltyagi reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26/27

Should we increase the PCL version here?

@kunaltyagi kunaltyagi added changelog: removal Meta-information for changelog generation needs: code review Specify why not closed/merged yet labels Sep 8, 2020
@kunaltyagi kunaltyagi self-requested a review September 8, 2020 13:38
@kunaltyagi kunaltyagi added the needs: feedback Specify why not closed/merged yet label Sep 8, 2020
@larshg
Copy link
Contributor Author

larshg commented Sep 8, 2020

If we increase, we will get errors instead of warnings right? And there are still some deprecations about the concatenatePointCloud which are not handled.

Which would cripple the CI?

@kunaltyagi
Copy link
Member

Got it. In that case, let's not 😄

@kunaltyagi kunaltyagi removed the needs: feedback Specify why not closed/merged yet label Sep 8, 2020
@kunaltyagi kunaltyagi changed the title Remove 1.12 deprecated items Remove deprecated items as scheduled for v1.12 (except concatenatePointCloud) Sep 8, 2020
@kunaltyagi kunaltyagi changed the title Remove deprecated items as scheduled for v1.12 (except concatenatePointCloud) Remove deprecated items as scheduled in preparation of v1.12 (except concatenatePointCloud) Sep 8, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.12.0 milestone Sep 12, 2020
@larshg larshg requested a review from mvieth September 25, 2020 07:58
@larshg larshg requested a review from kunaltyagi October 1, 2020 10:32
@larshg larshg requested a review from kunaltyagi October 3, 2020 19:43
@kunaltyagi
Copy link
Member

Today's a green day for @larshg

@larshg larshg force-pushed the Remove1.12Depcrecated branch from 87e6265 to 31dd8f4 Compare October 9, 2020 20:44
@larshg
Copy link
Contributor Author

larshg commented Oct 9, 2020

I have squashed correction commits to their respective commits. Please merge either of you, @kunaltyagi or @mvieth. So we can get rid of a lot of warnings on windows at least 😄

@larshg larshg force-pushed the Remove1.12Depcrecated branch from 31dd8f4 to e3ac902 Compare October 9, 2020 20:50
@kunaltyagi kunaltyagi merged commit 3906e52 into PointCloudLibrary:master Oct 10, 2020
@larshg larshg deleted the Remove1.12Depcrecated branch October 10, 2020 16:30
@larshg larshg mentioned this pull request Nov 30, 2020
Closed
@larshg larshg mentioned this pull request Jul 11, 2021
Closed
@larshg larshg mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho left review comments

@mvieth mvieth mvieth approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: removal Meta-information for changelog generation needs: code review Specify why not closed/merged yet
Projects
None yet
Milestone
pcl-1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@larshg @kunaltyagi @SergioRAgostinho @mvieth