Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "redundant" test condition in pcl_targets.cmake. #2569

Closed
SergioRAgostinho opened this issue Oct 19, 2018 · 2 comments · Fixed by #4006
Closed

Remove "redundant" test condition in pcl_targets.cmake. #2569

SergioRAgostinho opened this issue Oct 19, 2018 · 2 comments · Fixed by #4006
Labels
module: cmake needs: pr merge Specify why not closed/merged yet

Comments

@SergioRAgostinho
Copy link
Member

@jspricke Actually, do you see any reason for this test you referenced:

if(NOT ${EXT_DEP_FOUND} OR (NOT (${EXT_DEP_FOUND} STREQUAL "TRUE")))

Why isn't the first part of the condition sufficient? Looking at the Git history, this was added as a single commit and does not provide any motivation. Maybe we just drop it? Or better after the release?

Originally posted by @taketwo in #2563 (comment)

@jspricke
Copy link
Member

my best bet would be https://cmake.org/cmake/help/latest/policy/CMP0012.html bot no idea otherwise.

shrijitsingh99 added a commit to shrijitsingh99/pcl that referenced this issue May 1, 2020
This behaviour was possibly introduced due do to CMP0012 (PointCloudLibrary#2569)
@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@kunaltyagi kunaltyagi added the needs: pr merge Specify why not closed/merged yet label May 20, 2020
@stale stale bot removed the status: stale label May 20, 2020
SergioRAgostinho pushed a commit that referenced this issue May 21, 2020
This behaviour was possibly introduced due do to CMP0012 (#2569)
koide3 pushed a commit to koide3/pcl that referenced this issue Jul 6, 2020
This behaviour was possibly introduced due do to CMP0012 (PointCloudLibrary#2569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cmake needs: pr merge Specify why not closed/merged yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants