-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "redundant" test condition in pcl_targets.cmake. #2569
Labels
Comments
my best bet would be https://cmake.org/cmake/help/latest/policy/CMP0012.html bot no idea otherwise. |
shrijitsingh99
added a commit
to shrijitsingh99/pcl
that referenced
this issue
May 1, 2020
This behaviour was possibly introduced due do to CMP0012 (PointCloudLibrary#2569)
Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
SergioRAgostinho
pushed a commit
that referenced
this issue
May 21, 2020
This behaviour was possibly introduced due do to CMP0012 (#2569)
koide3
pushed a commit
to koide3/pcl
that referenced
this issue
Jul 6, 2020
This behaviour was possibly introduced due do to CMP0012 (PointCloudLibrary#2569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@jspricke Actually, do you see any reason for this test you referenced:
pcl/cmake/pcl_targets.cmake
Line 113 in a602b19
Why isn't the first part of the condition sufficient? Looking at the Git history, this was added as a single commit and does not provide any motivation. Maybe we just drop it? Or better after the release?
Originally posted by @taketwo in #2563 (comment)
The text was updated successfully, but these errors were encountered: