Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential compiler flag behavior change #3347

Closed
kunaltyagi opened this issue Sep 16, 2019 · 2 comments
Closed

Potential compiler flag behavior change #3347

kunaltyagi opened this issue Sep 16, 2019 · 2 comments

Comments

@kunaltyagi
Copy link
Member

It appears that GCC has changed the behavior of -Wabi

Your Environment

  • Operating System and version: macOS Mojave 10.14.6
  • Compiler: GCC-9.1, GCC-9.2
  • PCL Version: master

Context

While compiling, gcc gives the following warning

[build] cc1plus: warning: '-Wabi' won't warn about anything [-Wabi]
[build] cc1plus: note: '-Wabi' warns about differences from the most up-to-date ABI, which is also used by default
[build] cc1plus: note: use e.g. '-Wabi=11' to warn about changes from GCC 7

Expected Behavior

No warnings

Possible Solution

Update the flags used for compilation
@taketwo
Copy link
Member

taketwo commented Oct 29, 2019

I don't see why we need this flag, so propose to remove it.

taketwo added a commit to taketwo/pcl that referenced this issue Oct 29, 2019
@taketwo
Add a new Azure pipeline for Ubuntu 19.10
6aa0331 
The new pipeline is a copy of the old 16.04 pipeline, the only
difference is which Docker image is used.

This commit also removes the `-Wabi` compiler flag as proposed in PointCloudLibrary#3347.
@taketwo taketwo mentioned this issue Oct 29, 2019
Merged
@taketwo
Copy link
Member

taketwo commented Oct 30, 2019

#3446 removed the flag.

@taketwo taketwo closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@taketwo @kunaltyagi