Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcd_viewer: Add support for absolute repositioning of point clouds. #1154

Merged
merged 1 commit into from
Mar 9, 2015

Conversation

j-oberlaender
Copy link
Contributor

This is useful when visualizing multiple .pcd files together.

This is useful when visualizing multiple .pcd files together.
taketwo added a commit that referenced this pull request Mar 9, 2015
pcd_viewer: Add support for absolute repositioning of point clouds.
@taketwo taketwo merged commit 0f3d1ab into PointCloudLibrary:master Mar 9, 2015
// Calculate transform if available.
if (pose_x.size () > i && pose_y.size () > i && pose_z.size () > i &&
pose_roll.size () > i && pose_pitch.size () > i && pose_yaw.size () > i)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I just saw this nice addition.
wouldn't it make sense if you could only give position parameters?
I think this is a very common application, when you for example want to show multiple object pcds in one run, just displaced by lets say 1 meter from each other?
For that a very nice addition would be to check if the pose_x,y,z sizes are one, i.e. only one displacement vector d
In that case the standard behaviour would be to displace each pointcloud with index Ind by d * Ind ?
What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to allow just translation. I would then just check the translation and rotation vector sizes separately, and assume an identity rotation matrix where none is given. I've just pushed a commit to my clone doing that, how do you like it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants