Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voxel_grid: color fix #1170

Closed
wants to merge 1 commit into from
Closed

Conversation

soyersoyer
Copy link
Contributor

downsample the alpha component too

@taketwo
Copy link
Member

taketwo commented Mar 7, 2015

Hi, could you have a look at a new class introduced in #586? Do you think it may be useful here?

@soyersoyer
Copy link
Contributor Author

I think it could be useful, except the downsample_all_data_=false case.
Should we create a templatized add function in the CentroidPoint class?

template < typename PointT2 > void add_as(const PointT& p) { ... accumulate as PointT2 ...}

@SergioRAgostinho
Copy link
Member

This addresses #1413. Searched the issues put forgot to check pull requests. I also wrote a fix plus a test but only for VoxelGrid. This pull request is missing patching voxel_grid.cpp:177.

I'll try to incorporate #586, this following week.

SergioRAgostinho added a commit to SergioRAgostinho/pcl that referenced this pull request Nov 8, 2015
@SergioRAgostinho SergioRAgostinho mentioned this pull request Nov 8, 2015
SergioRAgostinho added a commit to SergioRAgostinho/pcl that referenced this pull request Nov 12, 2015
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586. Includes extra tests for RGBA and for testing downsamplealldata=false
SergioRAgostinho added a commit to SergioRAgostinho/pcl that referenced this pull request Nov 12, 2015
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586.
Includes extra tests for RGBA and for testing downsamplealldata=false
SergioRAgostinho added a commit to SergioRAgostinho/pcl that referenced this pull request Nov 16, 2015
Addresses PointCloudLibrary#1413 , based on PointCloudLibrary#1170, modified to make use of PointCloudLibrary#586.
Includes extra tests for RGBA and for testing downsamplealldata=false
@jspricke jspricke closed this Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants