Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add davidSDK support in PCL #1216

Merged
merged 4 commits into from
May 5, 2015
Merged

Add davidSDK support in PCL #1216

merged 4 commits into from
May 5, 2015

Conversation

VictorLamoine
Copy link
Contributor

This pull request adds davidSDK support in the io module of the PCL.

  • The goal of this grabber is to be as thin as possible, it implements the bare minimum to grab clouds/meshes/images.
  • I tested the grabber on Linux only, it should work fine on Windows.
  • The grabber is veeeeeery slow because the meshes are sent via the JSON interface through the network or written to the disk and read (Windows only for the second option).

Possible improvements

See io/src/davidSDK_grabber.cpp

@VictorLamoine VictorLamoine changed the title David sdk Add davidSDK support in PCL Apr 27, 2015
@VictorLamoine
Copy link
Contributor Author

Ready to be reviewed!

taketwo
taketwo reviewed May 1, 2015
View reviewed changes
doc/tutorials/content/davidsdk.rst

sudo service smbd restart

Use the `setLocalAndRemotePaths <http://docs.pointclouds.org/trunk//classpcl_1_1_david_s_d_k_grabber.html#a504c6ad11cb7af25e8aa07d274063199>`_ function to set the local and remote paths, if you use the same path as above; this doesn't have to be called if the server is running of the same machine as the client.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use Sphinx/doxygen referencing here instead of hard-coded URLs?

@taketwo
Copy link
Member

taketwo commented May 1, 2015

Please rename the grabber h/cpp files to avoid using capital letters. Also here and there spaces are missing before braces ;)

Apart from that looks good to me.

@VictorLamoine
Copy link
Contributor Author

  • Sphinx/doxygen referencing (great feature!!)
  • Clean up includes
  • Lower case grabber h/cpp files
  • Missing spaces before braces

@jspricke
Copy link
Member

jspricke commented May 3, 2015

Looking good from my side.

taketwo added a commit that referenced this pull request May 5, 2015
@taketwo
Merge pull request #1216 from VictorLamoine/davidSDK
1d10947 
Add davidSDK support in PCL
@taketwo taketwo merged commit 1d10947 into PointCloudLibrary:master May 5, 2015
@VictorLamoine VictorLamoine deleted the davidSDK branch May 7, 2015 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VictorLamoine @taketwo @jspricke