kinfu LS: fix volume size calculation from pointers. #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsdf_memory_end is the last valid memory address, not the first invalid. Apparently, a similar fix was already applied to pointer_shift.cu. This fixes some artifacts in the reconstruction.
taketwo
added a commit
that referenced
this pull request
May 15, 2015
kinfu LS: fix volume size calculation from pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsdf_memory_end is the last valid memory address, not the first invalid.
The size must be (tsdf_memory_end - tsdf_memory_start + 1).
Apparently, a similar fix was already applied to pointer_shift.cu.
This fixes some artifacts at volume boundaries in the reconstruction.