Fix Android cross-compilation error #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the fix. Could you please insert spaces before braces to match PCL style? |
39cb8b6 introduced a cross-compilation error for Android where a build would fail with [...] pcl/common/include/pcl/pcl_macros.h:394:4: error: #error aligned_malloc not supported on your platform #error aligned_malloc not supported on your platform ^ pcl/common/include/pcl/pcl_macros.h:410:4: error: #error aligned_free not supported on your platform #error aligned_free not supported on your platform ^ [...] This patch adds a new CPP branch for Android to pcl_macros.h. The calls to memalign() and free() were checked against the malloc.h files from the Android NDK r13b.
|
sure thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
39cb8b6 introduced a cross-compilation error
for Android where a build would fail with
[...]
pcl/common/include/pcl/pcl_macros.h:394:4: error: #error aligned_malloc not
supported on your platform
#error aligned_malloc not supported on your platform
^
pcl/common/include/pcl/pcl_macros.h:410:4: error: #error aligned_free not
supported on your platform
#error aligned_free not supported on your platform
^
[...]
This patch adds a new CPP branch for Android to pcl_macros.h. The calls to
memalign() and free() were checked against the malloc.h files from the
Android NDK r13b.
Fixes #1773