Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linemod compile errors #1836

Merged
merged 1 commit into from
May 30, 2017

Conversation

woodychow
Copy link
Contributor

  • Two files had the same "#ifndef PCL_FEATURES_QUANTIZABLE_MODALITY"
  • Two files had the same GradientXY structure defined

@taketwo
Copy link
Member

taketwo commented Mar 6, 2017

This PointRGB type seems to be a duplicate of the standard RGB type, with an exception that the order of color channels is swapped. Perhaps it would be better to update the algorithm implementation to use the standard type.

@woodychow
Copy link
Contributor Author

woodychow commented Mar 6, 2017

I just realized it too. Let me change that. Thanks.

Edit: I just removed the PointRGB struct. It was not used anywhere in the code as point type is templated in the LineMOD classes.

@woodychow woodychow force-pushed the fix_linemod_compile branch from 50ed7e4 to 332156a Compare March 6, 2017 08:46
@jspricke jspricke merged commit 44ca257 into PointCloudLibrary:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants