-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add/remove of 3D text without custom viewport #2110
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8c77408
[VISU] Review from SergioRAgostinho.
frozar c3991a1
[TEST] Uncomment some test for visualisation.
frozar 8c05204
[TEST] Add the test demo_text_simple.
frozar 6d14398
[TEST] Add the test demo_text_simple_multiport.
frozar 5a228f6
[CODING_STYLE] Add spaces.
frozar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#include <pcl/point_types.h> | ||
|
||
#include <pcl/visualization/pcl_visualizer.h> | ||
|
||
int | ||
main (int argc, char** argv) | ||
{ | ||
pcl::visualization::PCLVisualizer viz ("Visualizator"); | ||
viz.addCoordinateSystem(1.0); | ||
|
||
viz.addText3D ("Following text", pcl::PointXYZ(0.0, 0.0, 0.0), | ||
1.0, 1.0, 0.0, 0.0, "id_following"); | ||
viz.spin (); | ||
double orientation[3] = {0., 0., 0.}; | ||
viz.addText3D ("Fixed text", pcl::PointXYZ(0.0, 0.0, 0.0), orientation, | ||
1.0, 0.0, 1.0, 0.0, "id_fixed"); | ||
viz.spin (); | ||
viz.removeText3D ("id_following"); | ||
viz.spin (); | ||
viz.removeText3D ("id_fixed"); | ||
viz.spin (); | ||
|
||
return (0); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
#include <pcl/point_types.h> | ||
|
||
#include <pcl/visualization/pcl_visualizer.h> | ||
|
||
int | ||
main (int argc, char** argv) | ||
{ | ||
pcl::visualization::PCLVisualizer viz ("Visualizator"); | ||
int leftPort(0); | ||
int rightPort(0); | ||
|
||
viz.createViewPort(0, 0, 0.5, 1, leftPort); | ||
viz.createViewPort(0.5, 0, 1, 1, rightPort); | ||
|
||
viz.addCoordinateSystem(1.0); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Space before the parenthesis from line 9 to 15. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, it's done. |
||
|
||
viz.addText3D ("Following text", pcl::PointXYZ(0.0, 0.0, 0.0), | ||
1.0, 1.0, 0.0, 0.0, "id_following", leftPort); | ||
viz.spin (); | ||
double orientation[3] = {0., 0., 0.}; | ||
viz.addText3D ("Fixed text", pcl::PointXYZ(0.0, 0.0, 0.0), orientation, | ||
1.0, 0.0, 1.0, 0.0, "id_fixed", rightPort); | ||
viz.spin (); | ||
viz.removeText3D ("id_following", leftPort); | ||
viz.spin (); | ||
viz.removeText3D ("id_fixed", rightPort); | ||
viz.spin (); | ||
|
||
return (0); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a blocking call which continuously runs the main loop? Shouldn't
spinOnce
be used instead? This comment is applicable for all the other calls tospin
you do.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact I was inspired by other tests from this directory, and the behavior is good. Blocking
spin()
method is correct. If you run the test, it allow you to see the effect of the different add/remove of text step by step. To pass to the next step, you just have to press "Q".If I change it with
spinOnce()
, I will not be able to even see the window: it will open and close instantly.