Added missing 8 bytes to compressed binary pcd length. #2281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compressed binary pcd files are read the size passed to mmap for memory mapping the file is 8 bytes to small, as the size of the two four byte unsigned integers used to store the uncompressed and compressed size of the data in the pcd file are not added to the total size. This can lead to a segfault, when the size of a pcd file is at most 8 bytes smaller than the next multiple of the page size of the virtual address space and if the next page after the last page used by mmap is not owned by the process.