Fix -Wdelete-non-virtual-dtor warnings
#2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons but non-virtual destructor [-Wdelete-non-virtual-dtor]
taketwo
approved these changes
Jan 15, 2019
|
@taketwo Can you restart Windows x64 build? No idea why build failed. |
|
Something to do with lack of space on the agent... I've seen this before. |
taketwo
changed the title
delete-non-virtual-dtor warnings
taketwo
changed the title
delete-non-virtual-dtor warnings-Wdelete-non-virtual-dtor warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning: delete called on non-final '...' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
I always added missing destructor. This could change behavior, because correct destructor should be now called.