Fix access to static members through instances #2776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are done by: run-clang-tidy -header-filter='.' -checks='-,readability-static-accessed-through-instance' -fix
There are some changes I would revert, because they don't increase readability
QApplication::exec()
vsapp.exec()
this->compute_oriented_point_pair_signature
=>pcl::recognition::ObjRecRANSAC::compute_oriented_point_pair_signature
(I believecompute_oriented_point_pair_signature
without any prefix is enough)Whats your opinion? What keep, what revert?