Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to static members through instances #2776

Conversation

SunBlack
Copy link
Contributor

Changes are done by: run-clang-tidy -header-filter='.' -checks='-,readability-static-accessed-through-instance' -fix

There are some changes I would revert, because they don't increase readability

  • QApplication::exec() vs app.exec()
  • this->compute_oriented_point_pair_signature => pcl::recognition::ObjRecRANSAC::compute_oriented_point_pair_signature (I believe compute_oriented_point_pair_signature without any prefix is enough)

Whats your opinion? What keep, what revert?

…dability-static-accessed-through-instance' -fix
@taketwo
Copy link
Member

taketwo commented Jan 16, 2019

I certainly like the changes pertaining to numeric_limits and npos. I am not convinced that the rest improves readability, at least for me. But to be honest, I do not really care. Maybe accept all changes just so that in (some undefined) future we can include this check without exceptions at CI.

@SunBlack
Copy link
Contributor Author

I adjusted a small bit (you can squash commits if you want). So this PR should be fine now.

@SergioRAgostinho SergioRAgostinho merged commit 96147f6 into PointCloudLibrary:master Jan 19, 2019
@SunBlack SunBlack deleted the readability-static-accessed-through-instance branch January 19, 2019 18:02
@taketwo taketwo changed the title Fix access static members through instances Fix access to static members through instances Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants