Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -mtune instead of -march on non-x86 CPUs #2868

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Use -mtune instead of -march on non-x86 CPUs #2868

merged 1 commit into from
Feb 18, 2019

Conversation

7680x4320
Copy link
Contributor

GCC compiler flag -march is the architecture specific option. So we should use -mtune instead of -march on such CPUs (e.g. PowerPC) (here for detail).

@taketwo taketwo changed the title Fix cmake for non-x86 CPUs Use -mtune instead of -march on non-x86 CPUs Feb 18, 2019
@SergioRAgostinho SergioRAgostinho merged commit 73f6af1 into PointCloudLibrary:master Feb 18, 2019
@7680x4320 7680x4320 deleted the fix-cmake-find-sse branch February 18, 2019 12:40
@taketwo taketwo changed the title Use -mtune instead of -march on non-x86 CPUs Use -mtune instead of -march on non-x86 CPUs Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@7680x4320 @taketwo @SergioRAgostinho