Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMP0072 to NEW to prefer GLVND over legacy OpenGL modules #3066

Merged
merged 1 commit into from
May 7, 2019

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented May 6, 2019

Fixes #3065.

I tested it with my Ubuntu VM and there I still get a valid OpenGL output, so I hope value NEW of CMP0072 doesn't break anything. (maybe a Mac OS user can test this PR before merging)

Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have any system with 3.11 to test.

@SergioRAgostinho
Copy link
Member

Tried it on OS X High Sierra with CMake 3.12. Unsurprisingly, managed to compile things. Actually our OS X CI is pretty modern in terms of software tools due to homebrew's distribution model.

This is good to go imo.

@SergioRAgostinho SergioRAgostinho merged commit c3aeb68 into PointCloudLibrary:master May 7, 2019
@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented May 7, 2019

Spoke too soon, as usual.

$ bin/pcl_sim_test_simple ../test/colored_cloud.pcd 
Manually generate a simulated RGB-D point cloud using pcl::simulation. For more information, use: bin/pcl_sim_test_simple -h
Status: Using GLEW 2.1.0
OpenGL 2.0 supported
GL_MAX_VIEWPORTS: 33371
SumReduce: levels: 4
Failed loading vertex shader
$

But this is happening even prior to your PR, so there's a problem already for who knows how long.

@SunBlack SunBlack deleted the CMP0072 branch May 7, 2019 08:54
@taketwo taketwo changed the title Set CMP0072 to NEW to prefer GLVND over legacy OpenGL modules Set CMP0072 to NEW to prefer GLVND over legacy OpenGL modules Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CMake CMP0072 warning (OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY")
3 participants