Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use using instead of typedef [test] #3112

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Jun 3, 2019

Changes are done by: run-clang-tidy -header-filter='.' -checks='-,modernize-use-using' -fix

@taketwo
Copy link
Member

taketwo commented Jun 8, 2019

@SergioRAgostinho these are mostly trivial PRs, but they touch a lot of files. It would be nice to merge them in timely fashion to avoid conflicts. For example, I hope to spend a few hours this weekend with smart pointer transition, and will likely to need to touch some of the lines covered by these PRs.

Do you have any concerns about these, something specific that holding us off? Or just lack of time to review?

@SergioRAgostinho
Copy link
Member

Do you have any concerns about these, something specific that holding us off? Or just lack of time to review?

Lack of time to review. Like I said, I'm not putting any priority in reviewing these PRs because they are time consuming and not in the goals for this release. That being said, they are fairly trivial in the changes they make, so feel I'm perfectly ok in merging them with just your review.

@taketwo taketwo merged commit 08e01f8 into PointCloudLibrary:master Jun 10, 2019
@SunBlack SunBlack deleted the modernize-use-using_test branch June 10, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants