Print descriptive error if PLY file not found #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
Looks good, thanks for contributing!
Minor note for the future: instead of PR title, put a reference to the issue you are fixing in the description together with a verb "closes" or "fixes". This way once the PR is merged, the issue will be closed automatically, which is convenient. (This time I've made this edit myself.)
|
Sure, didn't know of that sorry! :) |
SergioRAgostinho
approved these changes
Jun 11, 2019
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if file with name
file_nameexists first before trying to read it and print an error message noting that file was NOT found instead of the generic problem parsing header!.Closes #2766.