Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer C++ method std::abs over C method abs #3271

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Prefer C++ method std::abs over C method abs #3271

merged 1 commit into from
Aug 8, 2019

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Aug 6, 2019

Well I think (and hope) this is the biggest PR of current math function transformation.

Btw: To use regular expression with a wrong font is sometimes a bit ugly (l vs |) xD

([^:\w\."])(l|ll|f)?abs(l|f)?([^\w])

vs

([^:\w\."])(l|ll|f)?abs(l|f)?([^\w])

@taketwo taketwo merged commit e56df22 into PointCloudLibrary:master Aug 8, 2019
@SunBlack SunBlack deleted the use_std-abs branch August 8, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @taketwo @SergioRAgostinho