Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the resize logic in PCLBase #3315

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Simplify the resize logic in PCLBase #3315

merged 1 commit into from
Sep 10, 2019

Conversation

kunaltyagi
Copy link
Member

Current path has repeated logic with dissimilar code resulting in std::bad_alloc not being caught in one case.

@kunaltyagi kunaltyagi changed the title Simplifying the resize logic Simplifying the resize logic in PCLBase Aug 30, 2019
taketwo
taketwo approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kunaltyagi
Copy link
Member Author

I had a race condition in my code 😄

@kunaltyagi
Copy link
Member Author

Is the MacOS failure related to the issue #3288?

@taketwo
Copy link
Member

taketwo commented Sep 2, 2019

Yes, it's that, so just ignore it.

@taketwo taketwo merged commit 063c104 into PointCloudLibrary:master Sep 10, 2019
@kunaltyagi kunaltyagi deleted the pcl_base_simplify branch September 10, 2019 14:08
@taketwo taketwo changed the title Simplifying the resize logic in PCLBase Simplify the resize logic in PCLBase Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @taketwo