Remove vector.reserve() from hot path in cloud concatenation
#3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
requested changes
Sep 24, 2019
There was a problem hiding this comment.
Thanks for the investigation and quick fix. Please split into two commits and also add a short justification to the message for the reserve removing commit. This will simplify our lives if, in two-three years from now, we need to investigate some issues with the function.
kunaltyagi
force-pushed
the
fix_reserve
branch
from
4b153ca to
9686ffe
Compare
taketwo
approved these changes
Sep 24, 2019
|
Can confirm this speeds it up again. Please merge! |
taketwo
changed the title
vector.reserve() from hot path in cloud concatenation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reservein GCC and in clang with libstdc++ causes multiple allocations. Removing reserve allows similar logic to work in both cases.Also fixed an out of bounds memory access due to use of reserve in place of resize
@jasjuang This fixes the speed issue.
Fixes performance degradation caused by #3320 (see #3320 (comment)).