-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PLY parser more tolerant towards files not adhering to standard #3542
Make PLY parser more tolerant towards files not adhering to standard #3542
Conversation
Test 110: test_non_linear is flaky on my system |
6842d21
to
7e572a0
Compare
#3353 (comment) #3527 (comment) With better error messages, it'll be easier to understand what's wrong. Making PCL more fault tolerant will require:
PCL is not a UI tool and is also used in cases where there's near zero user feedback. As such, it needs to ensure that the input is perfect (or bail out with an error) and none of the above options can achieve that (without more extensive changes). Missing fields are a sign of a larger error and dealing with them will only cause more issues for the rest of the input file. A best effort reader will require configs and options and that'll take more effort. TLDR: Not against the proposal for a best-effort reader, just against that in the current provided API. |
7e572a0
to
8a7457c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that's convincing, thanks. Please squash.
Also addressing review comments
2a711d9
to
523e242
Compare
Better error messages, better loops, less indentation.
Supersedes and closes #3527 . Fixes #3487. Closes #3353