Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Grabber::toggle() method #3615

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Add Grabber::toggle() method #3615

merged 2 commits into from
Feb 4, 2020

Conversation

kunaltyagi
Copy link
Member

Easy way to toggle streaming devices. Works with concurrent controllers (dual isRunning)

Also, throw is deprecated in C++14

kunaltyagi added a commit to kunaltyagi/pcl that referenced this pull request Jan 31, 2020
@kunaltyagi
Fixing 6 MISRA rules
0e233e4 
Relies on PointCloudLibrary#3615 to do the toggling
@kunaltyagi kunaltyagi mentioned this pull request Jan 31, 2020
Merged
@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation module: io modernization labels Jan 31, 2020
@taketwo
Copy link
Member

taketwo commented Jan 31, 2020

Shouldn't we replace throw() with noexcept?

@kunaltyagi kunaltyagi force-pushed the grabber-toggle branch 4 times, most recently from 7d9cdf0 to d2962a6 Compare February 4, 2020 01:20
@taketwo
Copy link
Member

taketwo commented Feb 4, 2020

Maybe simply reduce this PR to what is declared in the description?

@kunaltyagi
Add a toggle option to grabber
f786bf4 
Easy way to toggle streaming devices. Works with concurrent controllers (dual `isRunning`)
@kunaltyagi
Adding noexcept to dtor, removing ctor
71e81c5
@kunaltyagi kunaltyagi mentioned this pull request Feb 4, 2020
Merged
@taketwo taketwo merged commit 58e1b1e into PointCloudLibrary:master Feb 4, 2020
@kunaltyagi kunaltyagi deleted the grabber-toggle branch February 4, 2020 16:16
kunaltyagi added a commit to kunaltyagi/pcl that referenced this pull request Feb 4, 2020
@kunaltyagi
Fixing 6 MISRA rules
e122485 
Relies on PointCloudLibrary#3615 to do the toggling
@taketwo taketwo changed the title Add a toggle option to grabber Add Grabber::toggle() method Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
changelog: enhancement Meta-information for changelog generation module: io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @taketwo