Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing standard includes, reduce warnings in doxygen-enabled builds #3755

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

aPonza
Copy link
Contributor

@aPonza aPonza commented Mar 16, 2020

I can fix the namespace 'std' stuff tomorrow

from #3744 (comment)

This reduces the doxygen-clang log by 1075 lines, bringing it to 16880 if we consider the ones from #3701 as done. There is absolutely no dependency between these two PRs though.

Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: docs needs: more work Specify why not closed/merged yet labels Mar 16, 2020
@kunaltyagi kunaltyagi changed the title Fix missing standard includes Fix missing standard includes, reduce warnings in doxygen-enabled builds Mar 16, 2020
@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation and removed changelog: fix Meta-information for changelog generation labels Mar 16, 2020
@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet labels Mar 16, 2020
@aPonza
Copy link
Contributor Author

aPonza commented Mar 16, 2020

d:\a\1\s\surface\include\pcl\surface\impl\surfel_smoothing.hpp(84): fatal error C1083: Cannot open compiler intermediate file: 'pcl_surface.dir\Release\surfel_smoothing.obj': Not enough space [D:\a\build\surface\pcl_surface.vcxproj]
LINK : fatal error LNK1257: code generation failed [D:\a\build\surface\pcl_surface.vcxproj]

link

#include <algorithm>
#include <cmath>
#include <cstddef>
// #include <iostream>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to keep the comment around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented lines like

//std::cerr << min_sqr_distance;

@SergioRAgostinho SergioRAgostinho added needs: author reply Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet needs: author reply Specify why not closed/merged yet labels Mar 16, 2020
@SergioRAgostinho SergioRAgostinho merged commit 995a134 into PointCloudLibrary:master Mar 17, 2020
@aPonza aPonza deleted the namespace_std branch March 17, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation module: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants