Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GNUC macro name #3830

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fix GNUC macro name #3830

merged 1 commit into from
Mar 30, 2020

Conversation

mvieth
Copy link
Member

@mvieth mvieth commented Mar 30, 2020

It seems like there was an underscore too much each, or am I missing something here?
Introduced in #3823

SergioRAgostinho
SergioRAgostinho approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit.
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

@SergioRAgostinho SergioRAgostinho added module: common changelog: fix Meta-information for changelog generation labels Mar 30, 2020
@SergioRAgostinho SergioRAgostinho merged commit 2b00acc into PointCloudLibrary:master Mar 30, 2020
@mvieth mvieth deleted the macro_fix branch March 31, 2020 09:39
@taketwo taketwo removed the changelog: fix Meta-information for changelog generation label Mar 31, 2020
@taketwo
Copy link
Member

taketwo commented Mar 31, 2020

Removing changelog: fix because it fixes a mistake that was made a few PRs before. No need to expose these inner workings in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
module: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvieth @taketwo @SergioRAgostinho