[search] Use better types for indices: int -> index_t, std::vector<int> ->Indices

[mvieth]

No description provided.

[taketwo]

LGTM besides from the inline comments.

[kunaltyagi]

Some files still have the removed type alias.

@taketwo Which option is better:

• keep the type-alias in the class (referring to the global type alias): Current patch + some places that still need updating
• keep the type-alias in the class (referring to the type alias in PCLBase): Needs some work, but is more uniform in the sense of not using the global alias everywhere
• to deprecate it in favor of pcl::IndicesPtr: Needs deprecation, but is more uniform in the sense of using the global alias everywhere

[taketwo]

index_t is global, Indices is global, so it only makes sense to me that IndicesPtr is global as well. What's your opinion?

[kunaltyagi]

Strictly speaking IndicesPtr is an implementation detail of the classes. On the other hand, it is very prevalent. Conclusion: anything works.

[taketwo]

IndicesPtr is an implementation detail of the classes

In which sense? IndicesPtr is in the API of every PCL class because of the setIndices()/getIndices() methods inherited from PCLBase. So it's globally used, it's the same in every class, and users need to be aware of it.

[kunaltyagi]

In which sense?

If I were to change the type in PCLBase, global IndicesPtr will need to be changed. This is a technicality only, and due to all classes being related to PCLBase in one way or another, having it global isn't bad, or to quote myself: "anything works".

The choices I listed were:

• Use IndicesPtr as global: 2 votes for, agreed upon
• Deprecate (or not) the IndicesPtr defined inside the classes: needs decision upon

[taketwo]

Is there anything left to be done here?

[kunaltyagi]

Nope. The uniformity across all classes can be addressed later. I have an idea of how to do that.

[taketwo]

Please squash 1st and 3rd commits.

[mvieth]

@taketwo done