Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and warn user about missing normals in OrganizedMultiPlaneSegmentation #3861

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Check and warn user about missing normals in OrganizedMultiPlaneSegmentation #3861

merged 2 commits into from
Apr 20, 2020

Conversation

daniel-packard
Copy link
Contributor

fixes #3855

Add guard clauses and error messages as described in the related issue.

@daniel-packard daniel-packard changed the title Add guard clauses to check for required inputs, with error message Improve error handling in OrganizedMultiPlaneSegmentation Apr 3, 2020
@kunaltyagi kunaltyagi added module: segmentation needs: code review Specify why not closed/merged yet changelog: enhancement Meta-information for changelog generation labels Apr 3, 2020
@taketwo taketwo changed the title Improve error handling in OrganizedMultiPlaneSegmentation Check and warn user about missing normals in OrganizedMultiPlaneSegmentation Apr 5, 2020
@SergioRAgostinho SergioRAgostinho self-requested a review April 6, 2020 07:32
@SergioRAgostinho SergioRAgostinho removed the needs: code review Specify why not closed/merged yet label Apr 20, 2020
@SergioRAgostinho SergioRAgostinho merged commit d4ee172 into PointCloudLibrary:master Apr 20, 2020
truhoang pushed a commit to truhoang/pcl that referenced this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation module: segmentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[segmentation] Improve error handling in OrganizedMultiPlaneSegmentation::segment
4 participants