Fix MSVC warning C4067 (unexpected tokens following preprocessor directive - expected a newline)

[SunBlack]

Since #3634 I'm getting a C4067 warning (see Windows Azure builds):

pcl_macros.h(88): warning C4067: unexpected tokens following preprocessor directive - expected a newline

This is caused due to this bug.

Now I played a bit with godbolt and saw that #3634 even destroyed the deprecated warning for MSVC 2015 & 2017, as __has_cpp_attribute is only supportd since MSVC 2019. You can try it here (MSVC 19.1X => 2017, 19.2X => 2019).

As @taketwo mentioned here MSVC 2015 is the base line is not MSVC 2013 and MSVC 2015 (19.0) already supports [[deprecated]] see here I solved it by always using [[deprecated]] for MSVC.

Even I could not reproduce the issue from @office-florian-hubner with CUDA 10.2 on my MSVC 2017 (15.9.21) machine, I added the check again with __CUDACC__ (@office-florian-hubner If you see this: which environment you are using?)

[flowvision]

I'm using CUDA 10.1 and MSVC 2017. At the moment I use version 15.9.20 of MSVC 2017 but I think I updated it since I did #3634.

The problem for me was the nvcc on Windows neither recognized [[deprecated]] nor __declspec(deprecated). I would get the following error

error: attribute does not apply to any entity

I found some other projects which also added macros to handle the mess with the attributes. See
https://github.com/pytorch/pytorch/blob/master/c10/util/Deprecated.h
There is a comment on line 64 where they describe the same problem I had.

I wonder if they fixed this in CUDA 10.2 as you can't reproduce the problems I had.

[kunaltyagi]

Proper deprecation is already a headache. Why do compilers have to make it even more troublesome?