[Visualizer] Added unit test

[larshg]

Where points get removed and updatepointcloud is called on visualizer.

Basically @MaxFleur MCVE from here.

[kunaltyagi]

Small and sweet. Nice 😄

[kunaltyagi]

Just a note: There was no test failure. Did the test not run?

[larshg]

I updated to use the generator.

According to logs, the test is build(Ubuntu, OSx), but it was not run.

I'll have a look after this update and if it is still no run, we'll have to investigate...

Windows builds doesn't have VTK so they won't run it.

[larshg]

MacOS doesn't run the test_visualizer... So the others probably won't do it either... wierd.

[taketwo]

I guess CI does not have DISPLAY environment variable defined, so visualization tests are not built:

pcl/test/visualization/CMakeLists.txt

Line 15 in 917c22c

if(BUILD_features AND NOT UNIX OR (UNIX AND DEFINED ENV{DISPLAY}))

[kunaltyagi]

Do all visualization tests require a display? If so, we need to use xvfb (as a hack if this is true only for some tests)

[taketwo]

Well, all sounds too serious. There is a single file with two test cases.

[kunaltyagi]

I don't know how pcl_vis works (only know how it looks from an bird's eye view) 😅 Just adding a virtual buffer for all seemed the fastest way to get the tests running beyond dividing the vis tests in 2 parts.

[taketwo]

Just adding a virtual buffer for all seemed the fastest way to get the tests running

Somebody may give this a try, but I think it's certainly outside of the scope of this PR.

[kunaltyagi]

If anyone can confirm the failure induced due to the PR (or confirm that #4017 indeed solves the issue), we can merge #4017

[taketwo]

I've tried this PR, but the test passes (Ubuntu 18.04 + VTK 6.3).

[larshg]

Maybe its a VTK 8.2 issue only - most users reporting this issue has either been using 8.2 directly or updated to 8.2.

[larshg]

The test is set as being build in the cmake configuration.

but its not build and run in the Run Unit Test.

[taketwo]

The test is set as being build in the cmake configuration.

It's not the test itself, it's the tests_visualization module as a whole. (Which contains a single target test_visualization).

[larshg]

The test is set as being build in the cmake configuration.

It's not the test itself, it's the tests_visualization module as a whole. (Which contains a single target test_visualization).

Ahh, yes ofc.