[doc] Add information regarding header include order #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
approved these changes
May 3, 2020
kunaltyagi
added
changelog: enhancement
kunaltyagi
changed the title
kunaltyagi
added
needs: author reply
|
Webpage looks fine 👍 |
SunBlack
suggested changes
May 3, 2020
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
SunBlack
reviewed
May 3, 2020
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
|
|
SergioRAgostinho
approved these changes
May 7, 2020
Comment on lines
333
to
334
| i. All modular PCL includes, except main includes of common module | ||
| #. The main PCL includes of common module |
There was a problem hiding this comment.
The concept of what is a "main include of common module" is not clear. I had to go to the clang-format file to understand what it represented. Provide examples for what a "normal modular include" and a "main include of a common module" are.
kunaltyagi
added
needs: more work
kunaltyagi
approved these changes
May 7, 2020
kunaltyagi
added
needs: code review
|
Do squash before merging |
SergioRAgostinho
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3904