Fix unknown pragma warning on MSVC in test_type_traits.cpp

[SunBlack]

Should fix MSVC warning on Azure:

D:\a\1\s\test\common\test_type_traits.cpp(56): warning C4068: unknown pragma [D:\a\build\test\common\test_type_traits.vcxproj]
D:\a\1\s\test\common\test_type_traits.cpp(57): warning C4068: unknown pragma [D:\a\build\test\common\test_type_traits.vcxproj]
D:\a\1\s\test\common\test_type_traits.cpp(59): warning C4068: unknown pragma [D:\a\build\test\common\test_type_traits.vcxproj]

[SergioRAgostinho]

If the pragmas are not enclosed inside if-guards, then clang will complain about not recognizing #pragma warning(push). The osx build should confirm this.

[SunBlack]

If the pragmas are not enclosed inside if-guards, then clang will complain about not recognizing #pragma warning(push). The osx build should confirm this.

Oh really? I just copy & pasted it from here and there is no #ifdef around

pcl/common/include/pcl/point_cloud.h

Lines 188 to 200 in 1a21a4b

	/** \brief Copy constructor.
	* \param[in] pc the cloud to copy into this
	* \todo Erase once mapping_ is removed.
	*/
	// Ignore unknown pragma warning on MSVC (4996)
	#pragma warning(push)
	#pragma warning(disable: 4068)
	// Ignore deprecated warning on clang compilers
	#pragma clang diagnostic push
	#pragma clang diagnostic ignored "-Wdeprecated-declarations"
	PointCloud (const PointCloud<PointT> &pc) = default;
	#pragma clang diagnostic pop
	#pragma warning(pop)

[SunBlack]

ok @SergioRAgostinho you are right, macOS build is failing here (but why the hell not in pointcloud.h)?

But instead of fixing it by:

    // Ignore unknown pragma (C4068) warning on MSVC
    #ifdef _MSC_VER
    #pragma warning(push)
    #pragma warning(disable: 4068)
    #endif
    #pragma clang diagnostic push
    #pragma clang diagnostic ignored "-Wunused-local-typedef"
    PCL_MAKE_ALIGNED_OPERATOR_NEW
    #pragma clang diagnostic pop
    #ifdef _MSC_VER
    #pragma warning(pop)
    #endif

I could even use the shorter variant:

    #ifdef __clang__
    #pragma clang diagnostic push
    #pragma clang diagnostic ignored "-Wunused-local-typedef"
    #endif
    PCL_MAKE_ALIGNED_OPERATOR_NEW
    #ifdef __clang__
    #pragma clang diagnostic pop
    #endif

[SergioRAgostinho]

ok @SergioRAgostinho you are right, macOS build is failing here (but why the hell not in pointcloud.h)?

No clue. I really did not dig deep. It was more reporting what I experienced in the past.

The cleaner, the best. Go for it.

[stale]

Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this.

[kunaltyagi]

Could you please rebase and trigger another rebuild?

[SunBlack]

Done. Sorry for late response - didn't had time first and later our admins changed some certificates and my second PC didn't liked it (when I connected via RDP to the PC he lost the internet connection due to issues from 802.1X 😢 - hope it works now finally as before)