Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused exception variables in catch blocks #4064

Merged
merged 1 commit into from
May 8, 2020

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented May 7, 2020

This fixes warnings like:

D:\a\1\s\io\src\lzf_image_io.cpp(190): warning C4101: 'e': unreferenced local variable [D:\a\build\io\pcl_io.vcxproj]
D:\a\1\s\io\src\lzf_image_io.cpp(209): warning C4101: 'e': unreferenced local variable [D:\a\build\io\pcl_io.vcxproj]
D:\a\1\s\io\src\lzf_image_io.cpp(269): warning C4101: 'e': unreferenced local variable [D:\a\build\io\pcl_io.vcxproj]

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: ci labels May 7, 2020
@kunaltyagi kunaltyagi added the needs: testing Specify why not closed/merged yet label May 7, 2020
@SunBlack
Copy link
Contributor Author

SunBlack commented May 8, 2020

Fix worked, Azure shows now only 2 warnings of unreferenced local variable instead if 14. Both remaining warnings are in 3rd-Party code.

@kunaltyagi kunaltyagi removed the needs: testing Specify why not closed/merged yet label May 8, 2020
@kunaltyagi kunaltyagi merged commit 31e8d30 into PointCloudLibrary:master May 8, 2020
@SunBlack SunBlack deleted the unused_variables branch May 8, 2020 11:32
@taketwo taketwo changed the title Remove unused variables from exceptions Remove unused exception variables in catch blocks May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants