Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualization] Deprecate legacy OpenGL backend of VTK #4065

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented May 7, 2020

The OpenGL backend of VTK is deprecated and not available anymore since VTK 8.2. As the OpenGL2 backend is already supported since VTK 6.2 (our current minimal supported VTK version), we don't lose any compatibility by dropping support of old backend.

Note: Ubuntu 16.04 has only OpenGL1 backend precompiled in it's repo, during 18.04 already has OpenGL2. As the Standard Support of Ubuntu 16.04 ends April 2021 it is now a good time to deprecate the old backend - we will see if we have PCL 1.13 before April 2021 or not (even if I don't mind to drop a components a few month before end of it's release) 😉.

…ce VTK 8.2. As the OpenGL2 backend is already supported since VTK 6.2 (our current minimal supported VTK version), we don't lose any compatibility by dropping support of old backend.
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice line of thought. Any other support that needs to be deprecated considering EOL support?

@kunaltyagi kunaltyagi added changelog: deprecation Meta-information for changelog generation module: cmake module: visualization needs: code review Specify why not closed/merged yet needs: feedback Specify why not closed/merged yet labels May 7, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.11.0 milestone May 7, 2020
@SunBlack
Copy link
Contributor Author

SunBlack commented May 7, 2020

Related to VTK? I dunno. I just sreached for VTK_RENDERING_BACKEND_OPENGL_VERSION in CMake and code.

@kunaltyagi kunaltyagi removed the needs: feedback Specify why not closed/merged yet label May 7, 2020
@kunaltyagi kunaltyagi added needs: testing Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels May 7, 2020
@kunaltyagi kunaltyagi merged commit e647b08 into PointCloudLibrary:master May 8, 2020
@SunBlack SunBlack deleted the deprecate_legacy_vtk_opengl_backend branch May 8, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: deprecation Meta-information for changelog generation module: cmake module: visualization needs: testing Specify why not closed/merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants